PR 1234: keep the ignore rule name valid when the check has spaces

Your PR, reviewed twice at 7c93719: Cody's process (codyrancher/ai-skills 5f9619b) and ours, then merged and re-checked. Nothing was posted to GitHub.

Preview: harvesterrulenamer, built from 7c93719, backend Harvester .105 (v1.10.0-rc1 with the resource health controller). Baseline: harvester-main at aa6d11a, same backend.

Where it stands: ready for review, nothing to change

Both passes found nothing to fix, and Copilot's automatic review agrees. CI is green (7 checks), and Cody and houhoucoop are requested.

On main, Create Ignore Rule on Proactive Schedule Suspend fails with the 422 from the issue.
On the PR, the rule is created as harvester-controller-schedulevmbackup.proactive-schedule-suspend, the controller ignores the check under that name, and View, Edit and Delete work from the row menu.
Only the three schedule checks get new names, and rules for them could not exist before, so no earlier rule is lost.
Both new tests fail without the fix.

How the two passes compare

	Pass A (Cody's process)	Pass B (our process)
Verdict	No comments to file	Approve
Findings	0	0 blockers, 0 suggestions, 0 nits, 0 questions
Checked by both	The 422 on main, the rule created and applied on the PR against .105, View, Edit and Delete from the row menu, one-word names unchanged, the controller matching `spec.checkKey`.
Only one pass did	Before/after demo videos. Five acceptance criteria from the issue, each with a verdict. A side-effects walk over both callers, earlier rules, the controller, the docs sentence and the backport label.	All 35 check names the controller can write, run through main's and the PR's function: only the 3 schedule names change, and no two collide. 100,000 random names. Both new tests fail against main's function. UpgradeFailed's request captured on both builds. A coverage grid.
Left out	The docs sentence about rule names, which you decided to keep.	The ⋮ menu over the dialogs (same on main; see below) and the summary's few seconds of lag.
Output	Notes per pass, acceptance files, 2 videos	review.md, coverage.md, checked.md, draft.md, 17 screenshots
Cost	In this session	A separate agent: 92 tool calls, about 240k tokens, 26 minutes

Dropped after checking

The ⋮ menu drawn over the dialogs (Pass B, “seen, out of scope”). With normal clicks the menu closes as the dialog opens, on both builds (checked at 0.3s, 1.5s and 4s), so Pass B's screenshots likely came from how its script picked the item. It's the same on main either way, so not this PR.
Two checks getting the same name, a check with no letter or digit, dots turning into hyphens. Neither pass filed them: none of the 35 names the controller writes is affected.
The comment's punctuation differs from the rest of the file (Pass B, style only).
Pass B ran one read-only git show in the earlier fix clone, which its brief ruled out. It changed nothing and read no results there.

Pass A: Cody's process

Followed my-pr-full-review in this session, mapped to our setup: the PR preview for his dev server, harvester-main (rebuilt at aa6d11a) for his master build, local files instead of his harness, our recorder for the demos. The before demo's save was a dry run; the after demo used a real rule of mine, deleted on camera. .105 has no rules left.

Before this change: main, the 422.

With this change: created, ignored, found from the row menu, deleted.

Acceptance, from issue 12220

	Criterion	Verdict	How
AC1	Create Ignore Rule works on `Proactive Schedule Suspend`	Met	Seen on the PR: 201, the dialog closes, “created”. Main shows the 422.
AC2	The rule ignores the check	Met	Seen: ignored by the rule in 0.3s, errors 2 → 1, hidden, “(Ignored)” under Show ignored.
AC3	The other two schedule checks work the same	Met	By test and reading: .105 has no schedule in those states.
AC4	One-word checks keep their names	Met	By test, and Pass B saw UpgradeFailed send the same name on both builds.
AC5	View, Edit and Delete work on that rule	Met	Seen: read-only View, Save only after a change, Delete brings the check back.

His passes

Base review: Nothing to file. Both users of the function, the row menu's lookup and the dialog's create, get the same name.
1 Acceptance criteria: Five, written from the issue. It was filed by the PR's author, so it is a weaker standard than usual.
2 Acceptance verification: Five met, no gaps.
3 Simplify: Already as simple as it should be.
4 Side effects: Lookup, create, earlier rules, the controller and the backport were followed. The docs sentence is now inexact for the schedule checks; left as you decided.
5 Component reuse: No component introduced.
6 Design fidelity: No design.
7 Accessibility: Nothing in scope: no markup, styles or labels.
Verify, refine, final pass, remove suggestions, condense, master check: Nothing to run on: no comments were filed, which his process counts as a clean result.

Pass B: our process

A separate agent that didn't see Pass A. Verdict: approve, 0 blockers, 0 suggestions, 0 nits, 0 questions. What could have blocked and didn't: an earlier rule losing its menu (only the three schedule names change, and those rules were refused before), and the controller not applying the new name (it marked the check ignored with ignoredBy set to it). Its own rule was deleted through the UI.

Coverage

Dimension	component-health.js	health.test.js
correctness	cleared	cleared
tests	cleared: both new tests fail without the fix	cleared
a11y	n-a	n-a
i18n	n-a: the rule name is never shown	n-a
conventions	cleared: lint passes	cleared
errors	cleared: an unusable name still shows in the dialog's error banner	n-a
perf	cleared	n-a

What I'd post

Nothing. Neither pass has a comment, and it's your own PR, so the reviewers are the next step. If you want Pass A's videos in the PR, I can add them to the description, with the URL bar cropped off as usual.

Not checked by either pass

The other two schedule checks live: .105 has no schedule over its failure limit or out of sync.
The fix inside Rancher (extension mode) and as a non-admin user.
The released health add-on: .105 runs the controller from its chart (dev image), since no release has it yet.